docs: Fix typo in query-acceleration-blooms #14249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
type/docs
JStickler
approved these changes
Sep 24, 2024
|
This PR must be merged before a backport PR will be created. |
2 similar comments
|
This PR must be merged before a backport PR will be created. |
|
This PR must be merged before a backport PR will be created. |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-14249-to-release-3.0.x origin/release-3.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x b79210cd16c8379548ab61b36246948b0fab74a7When the conflicts are resolved, stage and commit the changes: If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-14249-to-release-3.0.x
# Create the PR body template
PR_BODY=$(gh pr view 14249 --json body --template 'Backport b79210cd16c8379548ab61b36246948b0fab74a7 from #14249{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'chore: [release-3.0.x] docs: Fix typo in query-acceleration-blooms' --body-file - --label 'size/XS' --label 'type/docs' --label 'backport' --base release-3.0.x --milestone release-3.0.x --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-14249-to-release-3.0.x
# Create a pull request where the `base` branch is `release-3.0.x` and the `compare`/`head` branch is `backport-14249-to-release-3.0.x`.
# Remove the local backport branch
git switch main
git branch -D backport-14249-to-release-3.0.x |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-14249-to-release-3.1.x origin/release-3.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x b79210cd16c8379548ab61b36246948b0fab74a7When the conflicts are resolved, stage and commit the changes: If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-14249-to-release-3.1.x
# Create the PR body template
PR_BODY=$(gh pr view 14249 --json body --template 'Backport b79210cd16c8379548ab61b36246948b0fab74a7 from #14249{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'chore: [release-3.1.x] docs: Fix typo in query-acceleration-blooms' --body-file - --label 'size/XS' --label 'type/docs' --label 'backport' --base release-3.1.x --milestone release-3.1.x --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-14249-to-release-3.1.x
# Create a pull request where the `base` branch is `release-3.1.x` and the `compare`/`head` branch is `backport-14249-to-release-3.1.x`.
# Remove the local backport branch
git switch main
git branch -D backport-14249-to-release-3.1.x |
loki-gh-app bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
(cherry picked from commit b79210c)
7 tasks
JStickler
pushed a commit
that referenced
this pull request
Sep 24, 2024
(cherry picked from commit b79210c)
JStickler
pushed a commit
that referenced
this pull request
Sep 24, 2024
(cherry picked from commit b79210c)
JStickler
added a commit
that referenced
this pull request
Sep 24, 2024
Co-authored-by: Huang Chen-Yi <[email protected]>
JStickler
added a commit
that referenced
this pull request
Sep 24, 2024
Co-authored-by: Huang Chen-Yi <[email protected]>
titaneric
commented
Sep 25, 2024
| @@ -152,7 +152,7 @@ Example calculation for storage requirements of blooms for a single tenant. | |||
|
|
|||
| Since reading blooms depends heavily on disk IOPS, Bloom Gateways should make use of multiple, | |||
| locally attached SSD disks (NVMe) to increase i/o throughput. | |||
| Multiple directories on different disk mounts can be specified using the `-bloom.shipper.working-directory` [setting][gateway-cfg] | |||
| Multiple directories on different disk mounts can be specified using the `-bloom.shipper.working-directory` [setting]storage-config-cfg] | |||
There was a problem hiding this comment.
Sorry, I miss the left bracket here, should I raise another PR?
There was a problem hiding this comment.
Yes, this one is already merged. Thanks for catching that!
7 tasks
This was referenced Sep 25, 2024
jeschkies
pushed a commit
to jeschkies/loki
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR